class/Widget/geometry.c: Allow reconfiguring grid cells#143
Closed
HaraldJoerg wants to merge 1 commit intodk:masterfrom
Closed
class/Widget/geometry.c: Allow reconfiguring grid cells#143HaraldJoerg wants to merge 1 commit intodk:masterfrom
HaraldJoerg wants to merge 1 commit intodk:masterfrom
Conversation
Owner
|
That check is needed actually if the slave to be checked in in a packer or a placer. I just committed exactly that |
Contributor
Author
|
Your fix c254fe0 does the trick, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just added a comment to commit 81d941c. This commit fixes the segfault for "mixed" widget configuration, but also prohibits calling
grid_configuretwice for the same cell. The docs say:I was actually using that capability: In my application I configure the grid rows from top to bottom. In each row, the cells immediately get their
colassigned. Only after the last row is defined, I assign therowattribute from top to bottom. The Prima grid rows are numbered from bottom to top, so I need to know the number of rows before assigning therowvalue for the topmost row.If there is a technical reason for the extra check, please reject the PR. The sentence in the documentation should be removed, and I'll reorder my code so that I can set row and column in one go.